Skip to content
This repository has been archived by the owner on May 17, 2024. It is now read-only.

fix: multiple TypeScript issues #3631

Merged
merged 6 commits into from
Jan 17, 2024
Merged

fix: multiple TypeScript issues #3631

merged 6 commits into from
Jan 17, 2024

Conversation

eddybrando
Copy link
Collaborator

@eddybrando eddybrando commented Jan 16, 2024 •
edited
Loading

Changes

This PR fixes several TypeScript issues in the codebase.

@eddybrando eddybrando self-assigned this Jan 16, 2024
y4izus
y4izus suggested changes Jan 16, 2024
View reviewed changes
Copy link
Contributor

@y4izus y4izus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I just have a request to follow consistency. Sometimes you use import type {... and sometimes import { type ...}. Following TS docs, I would suggest import type {... form, what do you think?

@eddybrando eddybrando requested a review from y4izus January 16, 2024 15:49
y4izus
y4izus approved these changes Jan 17, 2024
View reviewed changes
Copy link
Contributor

@y4izus y4izus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@y4izus y4izus merged commit 01b9830 into main Jan 17, 2024
5 of 6 checks passed
@y4izus y4izus deleted the fix/typescript-issues branch January 17, 2024 14:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@y4izus y4izus y4izus approved these changes

@techtolentino techtolentino Awaiting requested review from techtolentino techtolentino is a code owner

Assignees

@eddybrando eddybrando

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eddybrando @y4izus